[ 
https://issues.apache.org/jira/browse/HADOOP-10489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001900#comment-14001900
 ] 

Daryn Sharp commented on HADOOP-10489:
--------------------------------------

+1 I think it looks ok.  I almost wonder if some of the concurrent protection 
should occur in the Credentials itself, but it's probably not trivial due to 
the iterators.

> UserGroupInformation#getTokens and UserGroupInformation#addToken can lead to 
> ConcurrentModificationException
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10489
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10489
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Jing Zhao
>            Assignee: Robert Kanter
>         Attachments: HADOOP-10489.patch
>
>
> Currently UserGroupInformation#getTokens and UserGroupInformation#addToken 
> uses UGI's monitor to protect the iteration and modification of 
> Credentials#tokenMap. Per 
> [discussion|https://issues.apache.org/jira/browse/HADOOP-10475?focusedCommentId=13965851&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13965851]
>  in HADOOP-10475, this can still lead to ConcurrentModificationException.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to