[ 
https://issues.apache.org/jira/browse/HADOOP-10587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14006259#comment-14006259
 ] 

Andrew Wang commented on HADOOP-10587:
--------------------------------------

Hey Colin, we had a quick offline discussion about whether this is valid; I'm 
not sure whether this change will reduce peak memory consumption since all the 
temp bufs should be GC-able.

What's your take? Should we resolve?



> Use a thread-local cache in TokenIdentifier#getBytes to avoid creating many 
> DataOutputBuffer objects
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10587
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10587
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.4.0
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-10587.001.patch
>
>
> We can use a thread-local cache in TokenIdentifier#getBytes to avoid creating 
> many DataOutputBuffer objects.  This will reduce our memory usage (for 
> example, when loading edit logs), and help prevent OOMs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to