[
https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012621#comment-14012621
]
Alejandro Abdelnur commented on HADOOP-10632:
---------------------------------------------
Yi, looks very good, also how the read-pos/readFully is being handled to be
thread-safe.
2 final comments and after your opinion on those the patch is ready for commit:
* the {{getBufferSize/freeDB/freeBuffers/checkBufferSize}} methods are
duplicated in the both crypto input/output stream, wouldn't make sense to move
them to a {{CryptoStreamUtils}} class not to dup code?
* For read-pos/readFully logic, similarly to the {{bufferPool}} for BBs,
shouldn't we have a {{decryptorPool}}? As the decryptor creates a cipher and
this triggers a JCE selection and all that stuff in, that may be
expensive/synchronized.
> Minor improvements to Crypto input and output streams
> -----------------------------------------------------
>
> Key: HADOOP-10632
> URL: https://issues.apache.org/jira/browse/HADOOP-10632
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
> Reporter: Alejandro Abdelnur
> Assignee: Yi Liu
> Fix For: 3.0.0
>
> Attachments: HADOOP-10632.1.patch, HADOOP-10632.2.patch,
> HADOOP-10632.patch
>
>
> Minor follow up feedback on the crypto streams
--
This message was sent by Atlassian JIRA
(v6.2#6252)
