[ 
https://issues.apache.org/jira/browse/HADOOP-10633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14012924#comment-14012924
 ] 

Andrew Wang commented on HADOOP-10633:
--------------------------------------

Hey [~xieliang007], thanks for working on this. I think we need to be a careful 
with some of these swaps though:

- NoCacheFilter, HTTP is supposed to have actual dates, not monotonic ones, I 
think it's so e.g. caching proxies know when to expire things.
- AbstractService, I think startTime might be displayed somewhere, so I'd 
rather not change this either
- ADTSM, tokens are passed around between services, so again I think need to be 
real dates

NativeIO though looks like a valid swap, so maybe we just do that one? Thanks 
man.

> use Time#monotonicNow to avoid system clock reset
> -------------------------------------------------
>
>                 Key: HADOOP-10633
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10633
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: io, security
>    Affects Versions: 3.0.0
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>         Attachments: HADOOP-10633.txt
>
>
> let's replace System#currentTimeMillis with Time#monotonicNow



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to