[ 
https://issues.apache.org/jira/browse/HADOOP-10638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013016#comment-14013016
 ] 

Manikandan Narayanaswamy commented on HADOOP-10638:
---------------------------------------------------

Hey Aaron,

I see a bunch of comments from Hadoop QA and see two -1’s 
1. For not having new/modified tests. Its asks for a list of manual steps taken 
to verify the change - which I’ve already commented on.
2. One of the tests failed, and is marked as a regression with this call stack:

Test: org.apache.hadoop.ha.TestZKFailoverControllerStress.testExpireBackAndForth

org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode = NoNode
        at org.apache.zookeeper.server.DataTree.getData(DataTree.java:648)
        at org.apache.zookeeper.server.ZKDatabase.getData(ZKDatabase.java:371)
        at 
org.apache.hadoop.ha.MiniZKFCCluster.expireActiveLockHolder(MiniZKFCCluster.java:199)
        at 
org.apache.hadoop.ha.MiniZKFCCluster.expireAndVerifyFailover(MiniZKFCCluster.java:234)
        at 
org.apache.hadoop.ha.TestZKFailoverControllerStress.testExpireBackAndForth(TestZKFailoverControllerStress.java:84)

Not sure if this related to the changes I made, but can you please take a look.

Thanks!







> Updating hadoop-daemon.sh to work as expected when nfs is started as a 
> privileged user. 
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10638
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10638
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: nfs
>    Affects Versions: 2.4.0
>            Reporter: Manikandan Narayanaswamy
>            Assignee: Manikandan Narayanaswamy
>              Labels: patch
>         Attachments: 
> 0001-Picking-the-right-pid-file-when-running-NFS-as-privi.patch
>
>
> When NFS is started as a privileged user, this change sets up required 
> environment variables:
> HADOOP_PID_DIR = $HADOOP_PRIVILEGED_NFS_PID_DIR
> HADOOP_LOG_DIR = $HADOOP_PRIVILEGED_NFS_LOG_DIR
> HADOOP_IDENT_STRING = $HADOOP_PRIVILEGED_NFS_USER
> Also, along with the above, we also now collect ulimits for the right user.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to