[
https://issues.apache.org/jira/browse/HADOOP-10632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yi Liu updated HADOOP-10632:
----------------------------
Attachment: HADOOP-10632.3.patch
Hi Alejandro, thanks for your comments. The new patch includes update for your
comments.
{quote}
how the read-pos/readFully is being handled to be thread-safe.
{quote}
We use method local vars for read-pos/readFully.
{quote}
the {{getBufferSize/freeDB/freeBuffers/checkBufferSize}} methods are duplicated
in the both crypto input/output stream, wouldn't make sense to move them to a
CryptoStreamUtils class not to dup code?
{quote}
Right, let's reuse them in {{CryptoStreamUtils}}
{quote}
For read-pos/readFully logic, similarly to the bufferPool for BBs, shouldn't we
have a decryptorPool? As the decryptor creates a cipher and this triggers a JCE
selection and all that stuff in, that may be expensive/synchronized.
{quote}
Right, let's add a {{decryptorPool}}
> Minor improvements to Crypto input and output streams
> -----------------------------------------------------
>
> Key: HADOOP-10632
> URL: https://issues.apache.org/jira/browse/HADOOP-10632
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
> Reporter: Alejandro Abdelnur
> Assignee: Yi Liu
> Fix For: 3.0.0
>
> Attachments: HADOOP-10632.1.patch, HADOOP-10632.2.patch,
> HADOOP-10632.3.patch, HADOOP-10632.patch
>
>
> Minor follow up feedback on the crypto streams
--
This message was sent by Atlassian JIRA
(v6.2#6252)
