[ 
https://issues.apache.org/jira/browse/HADOOP-10561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liu updated HADOOP-10561:
----------------------------

    Attachment: HADOOP-10561.1.patch
                HADOOP-10561.1.patch

Thanks @Charles Lamb for your comments. The new patch includes update for your 
comments.
{quote}
The usage message is a little bit confusing. At first it was unclear to me that 
-ptopx was really -p with options for t, o, p, and x. I would if we could make 
this a little clearer by saying something like this instead?
public static final String USAGE = "\[-f\] \[-p | -p\[t|o|p|x\]\] <src> ... 
<dst>";
or maybe
public static final String USAGE = "\[-f\] \[-p | -p\[topx\]\] <src> ... <dst>";
{quote}
OK, let's use the {{\[-f\] \[-p | -p\[topx\]\] <src> ... <dst>}}. For the 
detail, user can get from {{hadoop fs -usage cp}}

{quote}
+ "must be a directory. Passing -p preserves status\n" +
+ "(\[topx\]) (timestamps, ownership, permission, XATTR). \n" +
+ "If -p is specified with no <arg>, then preserves " +
+ "timestamps, ownership, permission. Passing -f\n" +

Also, s/XATTR/XAttr/.
{quote}
Right, I change {{XATTR}} to {{xattr}}.


> Copy command with preserve option should handle Xattrs
> ------------------------------------------------------
>
>                 Key: HADOOP-10561
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10561
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs
>    Affects Versions: 3.0.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Yi Liu
>         Attachments: HADOOP-10561.1.patch, HADOOP-10561.1.patch, 
> HADOOP-10561.patch
>
>
> The design docs for Xattrs stated that we handle preserve options with copy 
> commands
> From doc:
> Preserve option of commands like “cp -p” shell command and “distcp -p” should 
> work on XAttrs. 
> In the case of source fs supports XAttrs but target fs does not support, 
> XAttrs will be ignored 
> with warning message



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to