[
https://issues.apache.org/jira/browse/HADOOP-10660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14025440#comment-14025440
]
Ravi Prakash commented on HADOOP-10660:
---------------------------------------
Thanks Ted! That makes sense. Perhaps we should do the same from GangliaSink
(in another JIRA)
In the latest patch, we are still not assigning writer = null after close()
bq. Should socket become a member of GraphiteSink and be closed in close() ?
http://docs.oracle.com/javase/7/docs/api/java/net/Socket.html#getOutputStream%28%29
{noformat}Closing the returned OutputStream will close the associated
socket.{noformat}
So closing the socket is unnecessary and should be removed from the patch.
> GraphiteSink should implement Closeable
> ---------------------------------------
>
> Key: HADOOP-10660
> URL: https://issues.apache.org/jira/browse/HADOOP-10660
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Chen He
> Attachments: HADOOP-10660-v2.patch, HADOOP-10660-v3.patch,
> HADOOP-10660.patch
>
>
> GraphiteSink wraps OutputStreamWriter around socket's output stream.
> Currently the socket is never closed.
> GraphiteSink should implement Closeable such that MetricsSystem can close the
> socket when it is stopped.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
