[ 
https://issues.apache.org/jira/browse/HADOOP-9648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028400#comment-14028400
 ] 

Jason Lowe commented on HADOOP-9648:
------------------------------------

This is primarily a YARN change rather than a change to common.  We either 
should have this JIRA track the hadoop-common change and file a separate for 
the container-executor fixes or move this to YARN and commit there.

Otherwise patch looks good overall, mostly nits:

- no check for strdup returning NULL
- should have braces even for 1-liners, e.g.: while (*p == '/')
- "Failed to mount cgroup controller, not support" should be "Failed to mount 
cgroup controller, not supported"


> Fix build native library on mac osx
> -----------------------------------
>
>                 Key: HADOOP-9648
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9648
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.0.4, 1.2.0, 1.1.2, 2.0.5-alpha
>            Reporter: Kirill A. Korinskiy
>            Assignee: Binglin Chang
>         Attachments: HADOOP-9648-native-osx.1.0.4.patch, 
> HADOOP-9648-native-osx.1.1.2.patch, HADOOP-9648-native-osx.1.2.0.patch, 
> HADOOP-9648-native-osx.2.0.5-alpha-rc1.patch, HADOOP-9648.v2.patch
>
>
> Some patches for fixing build a hadoop native library on os x 10.7/10.8.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to