[jira] [Commented] (HADOOP-10673) Update rpc metrics when the call throws an exception

[Tsuyoshi OZAWA (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-10673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031731#comment-14031731
 ] 

Tsuyoshi OZAWA commented on HADOOP-10673:
-----------------------------------------

Thanks for the updating, Ming. It looks better approach to me. One additional 
point: if we can make the variables final, we can remove null check in 
{{Server#stop()}}.

{code}
    if (this.rpcMetrics != null) {
      this.rpcMetrics.shutdown();
    }
    if (this.rpcDetailedMetrics != null) {
      this.rpcDetailedMetrics.shutdown();
    }
{code}

> Update rpc metrics when the call throws an exception
> ----------------------------------------------------
>
>                 Key: HADOOP-10673
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10673
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>         Attachments: HADOOP-10673-2.patch, HADOOP-10673-4.patch, 
> HADOOP-10673-5.patch, HADOOP-10673.patch
>
>
> Currently RPC metrics isn't updated when the call throws an exception. We can 
> either update the existing metrics or have a new set of metrics in the case 
> of exception.



--
This message was sent by Atlassian JIRA
(v6.2#6252)