[
https://issues.apache.org/jira/browse/HADOOP-10696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14031742#comment-14031742
]
Mike Yoder commented on HADOOP-10696:
-------------------------------------
Looks like there are some whitespace issues:
{noformat}
$ git apply /mnt/shared/HADOOP-10696.patch.txt
/mnt/shared/HADOOP-10696.patch.txt:41: trailing whitespace.
protected Metadata(String cipher, int bitLength, String description,
/mnt/shared/HADOOP-10696.patch.txt:57: trailing whitespace.
/mnt/shared/HADOOP-10696.patch.txt:91: trailing whitespace.
list.add(reader.nextString());
/mnt/shared/HADOOP-10696.patch.txt:112: trailing whitespace.
/mnt/shared/HADOOP-10696.patch.txt:126: trailing whitespace.
warning: squelched 3 whitespace errors
warning: 8 lines add whitespace errors.
{noformat}
General comment - I was thinking that it would be more flexible and general to
be able to specify arbitrary key = value pairs instead of just tags. I know
you can specify arbitrary key=value pairs for keys for at least one key manager
on the market. (KMIP is even farther out there - you can specify arbitrary
data types as custom attributes... that's a little too much!) Sorry if this is
more work.
The code as written, though, looks straightforward and good.
-Mike
> Add optional tags to KeyProvider Options and Metadata
> -----------------------------------------------------
>
> Key: HADOOP-10696
> URL: https://issues.apache.org/jira/browse/HADOOP-10696
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HADOOP-10696.patch, HADOOP-10696.patch
>
>
> In addition to having an optional description, KeyProvider Options and
> Metadata should support optional tags to help categorize keys.
> This would be useful for visualization purposes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
