[
https://issues.apache.org/jira/browse/HADOOP-10279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14036407#comment-14036407
]
Arpit Agarwal commented on HADOOP-10279:
----------------------------------------
Hi Chris, thanks for the additional clarification.
This change looks fine to me. Just a couple of nitpicks:
# Coding style, spaces around {{=}} and operators.
# {{advanceIndex}} and {{getCurrentIndex}} look like they can be private.
> Create multiplexer, a requirement for the fair queue
> ----------------------------------------------------
>
> Key: HADOOP-10279
> URL: https://issues.apache.org/jira/browse/HADOOP-10279
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Chris Li
> Assignee: Chris Li
> Attachments: HADOOP-10279.patch, WeightedRoundRobinMultiplexer.java,
> subtask2_add_mux.patch
>
>
> The Multiplexer helps the FairCallQueue decide which of its internal
> sub-queues to read from during a poll() or take(). It controls the penalty of
> being in a lower queue. Without the mux, the FairCallQueue would have issues
> with starvation of low-priority requests.
> The WeightedRoundRobinMultiplexer is an implementation which uses a weighted
> round robin approach to muxing the sub-queues. It is configured with an
> integer list pattern.
> For example: 10, 5, 5, 2 means:
> * Read queue 0 10 times
> * Read queue 1 5 times
> * Read queue 2 5 times
> * Read queue 3 2 times
> * Repeat
--
This message was sent by Atlassian JIRA
(v6.2#6252)
