[
https://issues.apache.org/jira/browse/HADOOP-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Yu updated HADOOP-10710:
-----------------------------
Attachment: HADOOP-10710.test-patch.log
[~tucu], I tried "mvn clean test -DskipTests -DHadoopPatchProcess -Ptest-patch"
The build success. Here is the output.
I checked the test-patch script. here is how it check for failure
$MVN clean test -DskipTests -D${PROJECT_NAME}PatchProcess $NATIVE_PROFILE
-Ptest-patch > $PATCH_DIR/patchJavacWarnings.txt 2>&1
if [[ $? != 0 ]] ; then
JIRA_COMMENT="$JIRA_COMMENT
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail."
return 2
fi
In the Hadoop QA test output, there seems two extra empty lines, could that
cause the check fail?
======================================================================
======================================================================
Determining number of patched javac warnings.
======================================================================
======================================================================
/home/jenkins/tools/maven/latest/bin/mvn clean test -DskipTests
-DHadoopPatchProcess -Pnative -Ptest-patch >
/home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/patchJavacWarnings.txt
2>&1
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12651673/HADOOP-10710.005.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified test files.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4127//console
This message is automatically generated.
> hadoop.auth cookie is not properly constructed according to RFC2109
> -------------------------------------------------------------------
>
> Key: HADOOP-10710
> URL: https://issues.apache.org/jira/browse/HADOOP-10710
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.4.0
> Reporter: Alejandro Abdelnur
> Assignee: Juan Yu
> Attachments: HADOOP-10710.001.patch, HADOOP-10710.002.patch,
> HADOOP-10710.003.patch, HADOOP-10710.004.patch, HADOOP-10710.005.patch,
> HADOOP-10710.test-patch.log
>
>
> It seems that HADOOP-10379 introduced a bug on how hadoop.auth cookies are
> being constructed.
> Before HADOOP-10379, cookies were constructed using Servlet's {{Cookie}}
> class and corresponding {{HttpServletResponse}} methods. This was taking care
> of setting attributes like 'Version=1' and double-quoting the cookie value if
> necessary.
> HADOOP-10379 changed the Cookie creation to use a {{StringBuillder}} and
> setting values and attributes by hand. This is not taking care of setting
> required attributes like Version and escaping the cookie value.
> While this is not breaking HadoopAuth {{AuthenticatedURL}} access, it is
> breaking access done using {{HtttpClient}}. I.e. Solr uses HttpClient and its
> access is broken since this change.
> It seems that HADOOP-10379 main objective was to set the 'secure' attribute.
> Note this can be done using the {{Cookie}} API.
> We should revert the cookie creation logic to use the {{Cookie}} API and take
> care of the security flag via {{setSecure(boolean)}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)