[
https://issues.apache.org/jira/browse/HADOOP-10715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043980#comment-14043980
]
Babak Behzad commented on HADOOP-10715:
---------------------------------------
Alright, I had to change some stuff in order to make this work.
GraphiteSink#setWriter() method was used in order to be able to test
GraphiteSink via Mockito. This made it hard to make this method private. I used
Mockito's Whitebox functionality to set the private writer class member and
therefore I could get rid of this method as well. The patch is uploaded and
ready for review and test.
> Make GraphiteSink#setWriter() private
> -------------------------------------
>
> Key: HADOOP-10715
> URL: https://issues.apache.org/jira/browse/HADOOP-10715
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Ted Yu
> Priority: Minor
> Attachments: HADOOP-10715.patch
>
>
> During review of HADOOP-10660, Ravi brought up the notion of making
> GraphiteSink#setWriter() private.
> This JIRA is to address Ravi's comment.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
