[ 
https://issues.apache.org/jira/browse/HADOOP-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046195#comment-14046195
 ] 

Jason Lowe commented on HADOOP-10739:
-------------------------------------

Thanks chang for the patch!  Looks good overall, just a minor nit about the 
test case.  Most of the static class members that look like they really should 
be local variables for the specific test case method, e.g.: cmd, cmdargs, 
myuri, src/target vars, etc.  The only things that look appropriate for the 
class are mockFs and conf since that is what the static methods and classes 
need, and the others are specific to the test case.  Other test cases added 
later are unlikely to need these variables.

> Renaming a file into a directory containing the same filename results in a 
> confusing I/O error
> ----------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10739
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10739
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.4.0
>            Reporter: Jason Lowe
>            Assignee: chang li
>         Attachments: HADOOP-10739.patch
>
>
> Renaming a file to another existing filename says "File
> exists" but colliding with a file in a directory results in the cryptic
> "Input/output error".



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to