[
https://issues.apache.org/jira/browse/HADOOP-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054331#comment-14054331
]
Andrew Wang commented on HADOOP-10736:
--------------------------------------
Hi Mike, thanks for working on this! I had a few review comments:
* Nit: reviewers appreciate it when you version the filenames of uploaded
patches, e.g. "HADOOP-10736.002.patch" :)
* In KeyProvider#toString, let's convert the entire thing to use StringBuilder,
no need for MessageFormat. I'd also mildly prefer to print "null" with no
period rather than "none.".
* I think KeyShell is unique in Hadoop in using two hyphens for command-line
flags. Do you mind filing a follow-on JIRA to fix this? We might also be able
to use GenericOptionsParser, which supports parsing key-value pairs.
* Could add some quick error checking to make sure a user doesn't specify the
same key twice
* Is a value required? That is, specifying a null vs an empty string.
* Bunch of parsing questions. What if you want your key to have an equals sign
or a quote? I don't know how the commandline is parsed into a {{String[]}}
either, so some of the tests might not be executing realistic situations. Have
you tried these with actual "hadoop key" invocations? These issues might go
away if you use GenericOptionsParser; maybe we should do that conversion first
if so.
* In CreateCommand, the new sentence you added has two spaces after the period
rather than one, which is the style of the rest of the paragraph.
> Add key attributes to the key shell
> -----------------------------------
>
> Key: HADOOP-10736
> URL: https://issues.apache.org/jira/browse/HADOOP-10736
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.0.0
> Reporter: Mike Yoder
> Assignee: Mike Yoder
> Fix For: 3.0.0
>
> Attachments: HADOOP-10736.patch, HADOOP-10736.patch
>
>
> The recent work in HADOOP-10696 added attribute-value pairs to keys in the
> KMS. Now the key shell needs to be updated to set/get these attributes.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
