[ https://issues.apache.org/jira/browse/HADOOP-10781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056119#comment-14056119 ]
Hudson commented on HADOOP-10781: --------------------------------- FAILURE: Integrated in Hadoop-Hdfs-trunk #1799 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1799/]) move HADOOP-10781 to 2.6 (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608936) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt HADOOP-10781. Unportable getgrouplist usage breaks FreeBSD (Dmitry Sivachenko via Colin Patrick McCabe) (cmccabe: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1608869) * /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt * /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/hadoop_user_info.c > Unportable getgrouplist() usage breaks FreeBSD > ---------------------------------------------- > > Key: HADOOP-10781 > URL: https://issues.apache.org/jira/browse/HADOOP-10781 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 2.4.1 > Reporter: Dmitry Sivachenko > Assignee: Dmitry Sivachenko > Fix For: 2.6.0 > > Attachments: getgrouplist.patch > > > getgrouplist() has different return values on Linux and FreeBSD: > Linux: either the number of groups (positive) or -1 on error > FreeBSD: 0 on success or -1 on error > The return value of getgrouplist() is analyzed in Linux-specific way in > hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/security/hadoop_user_info.c, > in function hadoop_user_info_getgroups() which breaks FreeBSD. > In this function you have 3 choices for the return value > ret = getgrouplist(uinfo->pwd.pw_name, uinfo->pwd.pw_gid, > uinfo->gids, &ngroups); > 1) ret > 0 : OK for Linux, it will be zero on FreeBSD. I propose to change > this to ret >= 0 > 2) First condition is false and ret != -1: impossible according to manpage > 3) ret == 1 -- OK for both Linux and FreeBSD > So I propose to change "ret > 0" to "ret >= 0" and (optionally) return 2nd > case. -- This message was sent by Atlassian JIRA (v6.2#6252)