[jira] [Commented] (HADOOP-10735) Fall back AesCtrCryptoCodec implementation from OpenSSL to JCE if non native support.

[Uma Maheswara Rao G (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-10735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056163#comment-14056163
 ] 

Uma Maheswara Rao G commented on HADOOP-10735:
----------------------------------------------

Thanks a lot, Yi for the patch.
Overall patch looks good to me.
I have a question and a nits to address.

{code}
if (fallback.getCipherSuite() == codec.getCipherSuite()) {
          LOG.warn("Fallback to " + fallbackKlass.getName());
          return fallback;
        }
{code}
Want to understand why fallback suite can not have different cipherSuite?


{code}
else {
          LOG.warn("Incompatible crypto codec fallback is configured.");
        }
{code}
Please include invalid configuration item also in log


> Fall back AesCtrCryptoCodec implementation from OpenSSL to JCE if non native 
> support.
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10735
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10735
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: security
>    Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>             Fix For: fs-encryption (HADOOP-10150 and HDFS-6134)
>
>         Attachments: HADOOP-10735.001.patch
>
>
> If there is no native support or OpenSSL version is too low not supporting 
> AES-CTR, but {{OpensslAesCtrCryptoCodec}} is configured, we need to fall back 
> it to JCE implementation.



--
This message was sent by Atlassian JIRA
(v6.2#6252)