[
https://issues.apache.org/jira/browse/HADOOP-10806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058266#comment-14058266
]
Wenwu Peng commented on HADOOP-10806:
-------------------------------------
Thanks Colin for patch, Overview,Looks good for me +1,
There is only minor comment,
Better to add error code type "ENOTSUP" to hadoop_err.c
+ return hadoop_lerr_alloc(ENOTSUP, "parse_permission(%s): "
+ "can't parse non-octal permissions (yet)", str);
> ndfs: need to implement umask, pass permission bits to hdfsCreateDirectory
> --------------------------------------------------------------------------
>
> Key: HADOOP-10806
> URL: https://issues.apache.org/jira/browse/HADOOP-10806
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: native
> Affects Versions: HADOOP-10388
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-10806-pnative.001.patch
>
>
> We need to pass in permission bits to {{hdfsCreateDirectory}}. Also, we need
> to read {{fs.permissions.umask-mode}} so that we know what to mask off of the
> permission bits (umask is always implemented client-side)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
