[
https://issues.apache.org/jira/browse/HADOOP-10825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061990#comment-14061990
]
Hadoop QA commented on HADOOP-10825:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655741/HADOOP-10811-10825.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
org.apache.hadoop.ipc.TestIPC
org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4272//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4272//console
This message is automatically generated.
> Refactor class creation logic in Configuration into nested class
> ----------------------------------------------------------------
>
> Key: HADOOP-10825
> URL: https://issues.apache.org/jira/browse/HADOOP-10825
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: conf
> Reporter: Chris Li
> Assignee: Chris Li
> Priority: Minor
> Attachments: HADOOP-10811-10825.patch
>
>
> This first patch refactors class creation inside Configuration into a nested
> class called ClassCreator (a pretty uninspired name; I’m up for better naming
> suggestions).
> Since this is a refactor that adds no new features, I have not included a
> test.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
