[
https://issues.apache.org/jira/browse/HADOOP-10824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062499#comment-14062499
]
Uma Maheswara Rao G commented on HADOOP-10824:
----------------------------------------------
Overall change looks good to me. Any reason for not making acls variable as
private?
{code}
+ volatile Map<Type, AccessControlList> acls;
{code}
+1 on answering above.
> Refactor KMSACLs to avoid locking
> ---------------------------------
>
> Key: HADOOP-10824
> URL: https://issues.apache.org/jira/browse/HADOOP-10824
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Reporter: Benoy Antony
> Assignee: Benoy Antony
> Attachments: HADOOP-10824.patch
>
>
> Currently _KMSACLs_ is made thread safe using _ReadWriteLock_. It is possible
> to safely publish the _acls_ collection using _volatile_.
> Similar refactoring has been done in
> [HADOOP-10448|https://issues.apache.org/jira/browse/HADOOP-10448?focusedCommentId=13980112&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13980112]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
