[
https://issues.apache.org/jira/browse/HADOOP-10839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062869#comment-14062869
]
Hadoop QA commented on HADOOP-10839:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12655904/HADOOP-10839.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ipc.TestIPC
org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4282//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4282//console
This message is automatically generated.
> Add unregisterSource() to MetricsSystem API
> -------------------------------------------
>
> Key: HADOOP-10839
> URL: https://issues.apache.org/jira/browse/HADOOP-10839
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Affects Versions: 2.4.1
> Reporter: shanyu zhao
> Assignee: shanyu zhao
> Attachments: HADOOP-10839.2.patch, HADOOP-10839.patch
>
>
> Currently the MetrisSystem API has register() method to register a
> MetricsSource but doesn't have unregister() method. This means once a
> MetricsSource is registered with the MetricsSystem, it will be there forever
> until the MetricsSystem is shut down. This in some cases can cause Java
> OutOfMemoryError.
> One such case is in file system metrics implementation. The new
> AbstractFileSystem/FileContext framework does not implement a cache so every
> file system access can lead to the creation of a NativeFileSystem instance.
> (refer to HADOOP-6356). And all these NativeFileSystem needs to share the
> same instance of MetricsSystemImpl, which means we cannot shut down
> MetricsSystem to clean up all the MetricsSources that has been registered but
> no longer active. Over time the MetricsSource instance accumulates and
> eventually we saw OutOfMemoryError.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
