[
https://issues.apache.org/jira/browse/HADOOP-10720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066812#comment-14066812
]
Alejandro Abdelnur commented on HADOOP-10720:
---------------------------------------------
[~asuresh], I like much better the wrapper approach, much cleaner. A few minor
follow ups:
*CommonConfigurationKeysPublic.java*:
* constants values should be {{.encrypted.key.}} instead of {{.key.}},
similarly the constant names. update doc as well.
*KMS.java*:
* unused imports
* cache constants/defaults here are not used, remove
* {{cryptoExtension}} assignment has funny indentation
* EEK_GENERATE op call should be a HTTP GET
* EEK_DECRYPT op should be a HTTTP POST with the eek as JSON payload
*KMSWebApp.java*:
* unused imports
*EncryptedKeyCachingProvider.java:*
* a better name would be {{EncryptedKeyPreGeneratorKeyProvider}}, not to
confuse with the cache provider that is coming.
> KMS: Implement generateEncryptedKey and decryptEncryptedKey in the REST API
> ---------------------------------------------------------------------------
>
> Key: HADOOP-10720
> URL: https://issues.apache.org/jira/browse/HADOOP-10720
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Arun Suresh
> Attachments: COMBO.patch, COMBO.patch, COMBO.patch, COMBO.patch,
> COMBO.patch, HADOOP-10720.1.patch, HADOOP-10720.10.patch,
> HADOOP-10720.11.patch, HADOOP-10720.12.patch, HADOOP-10720.2.patch,
> HADOOP-10720.3.patch, HADOOP-10720.4.patch, HADOOP-10720.5.patch,
> HADOOP-10720.6.patch, HADOOP-10720.7.patch, HADOOP-10720.8.patch,
> HADOOP-10720.9.patch, HADOOP-10720.patch, HADOOP-10720.patch,
> HADOOP-10720.patch, HADOOP-10720.patch, HADOOP-10720.patch
>
>
> KMS client/server should implement support for generating encrypted keys and
> decrypting them via the REST API being introduced by HADOOP-10719.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
