[ 
https://issues.apache.org/jira/browse/HADOOP-10887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072289#comment-14072289
 ] 

Andrew Wang commented on HADOOP-10887:
--------------------------------------

Nice work here Stephen, just a single nit:

- line longer than 80chars in ViewFs

+1 pending this though.

> Add XAttrs to ViewFs and make XAttrs + ViewFileSystem internal dir behavior 
> consistent
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10887
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs, test
>    Affects Versions: 3.0.0, 2.5.0
>            Reporter: Stephen Chu
>            Assignee: Stephen Chu
>         Attachments: HADOOP-10887.1.patch
>
>
> This is very similar to the work done in HADOOP-10845 (Add common tests for 
> ACLs in combination with viewfs)
> Here we make the XAttrs + ViewFileSystem internal dir behavior consistent. 
> Right now, when users attempt XAttr operation on an internal dir, they will 
> get an UnsupportedOperationException. Instead, we should throw the 
> ReadOnlyMountTable AccessControlException or the NotInMountPointException.
> We also add the XAttrs APIs to ViewFs. This involves adding them to 
> ChRootedFs as well. Also, {{listXAttrs}} is missing from FileContext, so we 
> should add that in.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to