[ 
https://issues.apache.org/jira/browse/HADOOP-10886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086779#comment-14086779
 ] 

Uma Maheswara Rao G commented on HADOOP-10886:
----------------------------------------------

Thanks a lot, Andrew for the review!
Sure, I will do that guidance part improvement for Exception message and will 
change to IOE.
And for the first comment, I think as part of verification of a test failures 
in TestDistributedFileSystem, I would have removed that unused import on my 
usual practice whenever I see unused import. I will leave that comment for now 
as I already pushed it? ( Not a big change and will not lead to any confusion 
with that changes)

> CryptoCodec#getCodecclasses throws NPE when configurations not loaded.
> ----------------------------------------------------------------------
>
>                 Key: HADOOP-10886
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10886
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134)
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>             Fix For: 3.0.0
>
>         Attachments: HADOOP-10886.patch
>
>
> There are some test cases which will not load the xml defaults. In this case, 
> CryptoCodec#getCodecclasses will fail with NPE.
> {noformat}
> java.lang.NullPointerException: null
>         at 
> com.google.common.base.Preconditions.checkNotNull(Preconditions.java:187)
>         at com.google.common.base.Splitter.split(Splitter.java:371)
>         at 
> org.apache.hadoop.crypto.CryptoCodec.getCodecClasses(CryptoCodec.java:100)
>         at 
> org.apache.hadoop.crypto.CryptoCodec.getInstance(CryptoCodec.java:54)
>         at 
> org.apache.hadoop.crypto.CryptoCodec.getInstance(CryptoCodec.java:91)
>         at 
> org.apache.hadoop.crypto.TestCryptoStreamsForLocalFS.init(TestCryptoStreamsForLocalFS.java:53)
> {noformat}
> https://builds.apache.org/job/Hadoop-fs-encryption-nightly/71/



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to