[
https://issues.apache.org/jira/browse/HADOOP-10919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090104#comment-14090104
]
Andrew Wang commented on HADOOP-10919:
--------------------------------------
This looks basically right, just a few review comments:
* Would be nice to quote paths in exception messages for clarity
* Could mention that checkPathsForReservedRaw expects fully-qualified paths
(i.e. not relative)
Test:
* testCopyCommandsWithRawXAttrs, setting the xattrs looks like it could be
turned into two loops. We also copy pasted the same xattr names and values in
checkXAttrs, seems like we could dedupe this. There's also a double semi-colon.
* Not a huge fan of the per-parameter in-line comments, not something I've seen
in Hadoop before. IDEs help you figure this out without a comment.
* checkXAttrs, would be better to do assertEquals than assertTrue for the size.
Should have error messages in all the asserts too.
* I would feel a bit better if we tested a relative destination with a ".." as
well, though I'm fairly sure that it works.
Thanks Charles!
> Copy command should preserve raw.* namespace extended attributes
> ----------------------------------------------------------------
>
> Key: HADOOP-10919
> URL: https://issues.apache.org/jira/browse/HADOOP-10919
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.0.0
> Reporter: Charles Lamb
> Assignee: Charles Lamb
> Attachments: HADOOP-10919.001.patch
>
>
> Refer to the doc attached to HDFS-6509 for background.
> Like distcp -p (see MAPREDUCE-6007), the copy command also needs to rpeserve
> extended attributes in the raw.* namespace by default whenever the src and
> target are in /.reserved/raw. A new option to -p (preserve) which explicitly
> disables this copy will be added.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
