[
https://issues.apache.org/jira/browse/HADOOP-10335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094906#comment-14094906
]
Arpit Agarwal commented on HADOOP-10335:
----------------------------------------
Hi [~benoyantony], my comments below:
# Do we need the check for null IP Address at CombinedIPWhiteList.isIn? In any
case we can skip the LOG.warn call. I am not sure how often that call could
fire, if at all.
# \@Override annotation missing WhitelistBasedResolver.getServerProperties
# Rename sasl_Props to saslProps. We avoid underscores for non-static members.
# Can we eliminate ConstantIPList? It looks like an overkill to have a class
for one constant. We could just have a hardcoded check for 127.0.0.1 in
CombinedIPWhiteList.isIn. I also think ReloadableIPList looks like an
unnecessary interface. Perhaps CacheableIPList could just hold a pointer to
FileBasedIPList. What do you think?
# Add InterfaceAudience annotations? The default is now assumed to be Private.
# Bad indentation - FileBasedIPList.java:51.
# Coding convention - single spaces around operators, no space after function
name e.g. at WhitelistBasedResolver:124, 107, 112, 124, CombinedIPWhiteList:29,
45, 50.
> An ip whilelist based implementation to resolve Sasl properties per connection
> ------------------------------------------------------------------------------
>
> Key: HADOOP-10335
> URL: https://issues.apache.org/jira/browse/HADOOP-10335
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Benoy Antony
> Assignee: Benoy Antony
> Attachments: HADOOP-10335.patch, HADOOP-10335.patch,
> HADOOP-10335.patch, HADOOP-10335.pdf
>
>
> As noted in HADOOP-10221, it is sometimes required for a Hadoop Server to
> communicate with some client over encrypted channel and with some other
> clients over unencrypted channel.
> Hadoop-10221 introduced an interface _SaslPropertiesResolver_ and the
> changes required to plugin and use _SaslPropertiesResolver_ to identify the
> SaslProperties to be used for a connection.
> In this jira, an ip-whitelist based implementation of
> _SaslPropertiesResolver_ is attempted.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
