[ 
https://issues.apache.org/jira/browse/HADOOP-10967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095487#comment-14095487
 ] 

Hadoop QA commented on HADOOP-10967:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12661442/HADOOP-10967.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ipc.TestDecayRpcScheduler

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4461//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/4461//console

This message is automatically generated.

> Improve DefaultCryptoExtension#generateEncryptedKey performance 
> ----------------------------------------------------------------
>
>                 Key: HADOOP-10967
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10967
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.6.0
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>         Attachments: HADOOP-10967.001.patch
>
>
> This JIRA is to improve generateEncryptedKey performance:
> *1.* SecureRandom#generateSeed is very slow, we should use 
> SecureRandom#nextBytes to generate the {{IV}} which is much faster. 
> *2.* Define SecureRandom as threadlocal object which can improve the 
> performance a bit.
> *3.* Use {{new SecureRandom()}} instead of SHA1PRNG, the former has better 
> entropy.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to