[
https://issues.apache.org/jira/browse/HADOOP-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14100412#comment-14100412
]
Hadoop QA commented on HADOOP-9913:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12662433/HADOOP-9913.3.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ipc.TestDecayRpcScheduler
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4496//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/4496//console
This message is automatically generated.
> Document time unit to RpcMetrics.java
> -------------------------------------
>
> Key: HADOOP-9913
> URL: https://issues.apache.org/jira/browse/HADOOP-9913
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation, metrics
> Affects Versions: 3.0.0, 2.1.0-beta
> Environment: trunk
> Reporter: Akira AJISAKA
> Assignee: Akira AJISAKA
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-9913.2.patch, HADOOP-9913.3.patch,
> HADOOP-9913.patch
>
>
> In o.a.h.ipc.metrics.RpcMetrics.java, metrics are declared as follows:
> {code}
> @Metric("Queue time") MutableRate rpcQueueTime;
> @Metric("Processsing time") MutableRate rpcProcessingTime;
> {code}
> Since some users may confuse which unit (sec or msec) is correct, they should
> be documented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
