[ 
https://issues.apache.org/jira/browse/HADOOP-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111560#comment-14111560
 ] 

Alejandro Abdelnur commented on HADOOP-10758:
---------------------------------------------

*index.apt.vm*:

{code}
  KMS also supports access control for all non-read operations at the Key level.
  All Key Access operations are classified as :
  MANAGEMENT - createKey, deleteKey, rolloverNewVersion
  GENERATE_EEK - generateEncryptedKey, warmUpEncryptedKeys
  DECRYPT_EEK - decryptEncryptedKey;
  ALL - all of the above;
{code}

The above will show as a single paragraph, it should be:

{code}
  KMS also supports access control for all non-read operations at the Key level.
  All Key Access operations are classified as :

    * MANAGEMENT - createKey, deleteKey, rolloverNewVersion

    * GENERATE_EEK - generateEncryptedKey, warmUpEncryptedKeys

    * DECRYPT_EEK - decryptEncryptedKey

    * ALL - all of the above
{code}

The line "KMS also supports access control for all non-read operations at the 
Key level. All Key Access operations are classified as :" should read "KMS 
supports access control on per key basis. A Key can have the following ACLs 
types:"

The line "These can also be defined in the KMS <<<etc/hadoop/kms-acls.xml>>> as 
follows 
" should be "Key ACLs are defined in the <<<etc/hadoop/kms-acls.xml>>> 
configuration file which is hot-reloadable, for example:"

*HotReloadingACLs.java/KeyACLs.java*:

Would be easier to piggyback on the {{KMSACLs}} class which already does 
hot-reloading reloading? Then we can have a {{hasAccessToKey(String keyName, 
String user, KeyOptType opType)}} method there and use that through out the 
code.

*default Key ACLs*:

It seems we should have a set of configs with the default key ACLs. The 
{{hasAccessToKey()}} method would fallback to the default Key ACLs if a 
specific key ACL is not defined.



> KMS: add ACLs on per key basis.
> -------------------------------
>
>                 Key: HADOOP-10758
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10758
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Arun Suresh
>         Attachments: HADOOP-10758.1.patch, HADOOP-10758.2.patch, 
> HADOOP-10758.3.patch
>
>
> The KMS server should enforce ACLs on per key basis.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to