[ 
https://issues.apache.org/jira/browse/HADOOP-10863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118392#comment-14118392
 ] 

Alejandro Abdelnur commented on HADOOP-10863:
---------------------------------------------

what about the failed KMS test?

*AccessControlList.java*:

* {{isUserInList()}} shouldn’t implement the logic and {{isUserAllowed()}} call 
it? yo could make {{isUserInList()}} final to avoid a subclass changing the 
behavior and breaking {{isUserAllowed}}.

other than that, LGTM.

> KMS should have a blacklist for decrypting EEKs
> -----------------------------------------------
>
>                 Key: HADOOP-10863
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10863
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Arun Suresh
>         Attachments: HADOOP-10863.1.patch, HADOOP-10863.2.patch, 
> HADOOP-10863.3.patch, HADOOP-10863.4.patch
>
>
> In particular, we'll need to put HDFS admin user there by default to prevent 
> an HDFS admin from getting file encryption keys.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to