[ 
https://issues.apache.org/jira/browse/HADOOP-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14126002#comment-14126002
 ] 

Gary Steelman commented on HADOOP-11032:
----------------------------------------

Thanks [~ozawa]. The test failures don't appear to be related to this patch. 

For fixing the exception thrown when StopWatch.stop() is called twice 
consecutively, ideally the fix is to simply not call stop() twice 
consecutively. I meant, however, we could submit a patch to the commons project 
to change the behavior of stop() to Log.warn("StopWatch is already in stopped 
state"); or be a no-op instead of throwing an Exception. 

> Replace use of Guava Stopwatch with Apache StopWatch
> ----------------------------------------------------
>
>                 Key: HADOOP-11032
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11032
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Gary Steelman
>            Assignee: Tsuyoshi OZAWA
>         Attachments: HADOOP-11032.1.patch, HADOOP-11032.2.patch, 
> HADOOP-11032.3.patch, HADOOP-11032.3.patch
>
>
> This patch reduces Hadoop's dependency on an old version of guava. 
> Stopwatch.elapsedMillis() isn't part of guava past v16 and the tools I'm 
> working on use v17. 
> To remedy this and also reduce Hadoop's reliance on old versions of guava, we 
> can use the Apache StopWatch (org.apache.commons.lang.time.StopWatch) which 
> provides nearly equivalent functionality. apache.commons.lang is already a 
> dependency for Hadoop so this will not introduce new dependencies. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to