[
https://issues.apache.org/jira/browse/HADOOP-11101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147510#comment-14147510
]
Hudson commented on HADOOP-11101:
---------------------------------
FAILURE: Integrated in Hadoop-trunk-Commit #6105 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/6105/])
HADOOP-11101. How about inputstream close statement from catch block to finally
block in FileContext#copy() ( Contributed by skrho ) (vinayakumarb: rev
dff95f7af899a4f2add791afbd20c8a1e33c7a36)
*
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
* hadoop-common-project/hadoop-common/CHANGES.txt
> How about inputstream close statement from catch block to finally block in
> FileContext#copy() ?
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-11101
> URL: https://issues.apache.org/jira/browse/HADOOP-11101
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.5.1
> Reporter: skrho
> Priority: Minor
> Attachments: HADOOP-11101_001.patch, HADOOP-11101_002.patch,
> HADOOP-11101_003.patch
>
>
> If IOException is happended, can be catched exception block..
> But another excpetion is happended, can't be catched exception block.. also
> Stream object can't be closed..
> try {
> in = open(qSrc);
> EnumSet<CreateFlag> createFlag = overwrite ? EnumSet.of(
> CreateFlag.CREATE, CreateFlag.OVERWRITE) :
> EnumSet.of(CreateFlag.CREATE);
> out = create(qDst, createFlag);
> IOUtils.copyBytes(in, out, conf, true);
> } catch (IOException e) {
> IOUtils.closeStream(out);
> IOUtils.closeStream(in);
> throw e;
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
