[ 
https://issues.apache.org/jira/browse/HADOOP-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162191#comment-14162191
 ] 

Chris Nauroth commented on HADOOP-7984:
---------------------------------------

Nice work, Akira!  I tested patch v4, calling all 4 main entry points, with and 
without a --loglevel option.  I did find one more spot that needs a change.  In 
yarn-env.cmd, we have this code:

{code}
if not defined YARN_ROOT_LOGGER (
  set YARN_ROOT_LOGGER=INFO,console
)
{code}

It needs to be changed to this:

{code}
if not defined YARN_ROOT_LOGGER (
  set YARN_ROOT_LOGGER=%HADOOP_LOGLEVEL%,console
)
{code}

I'm +1 for the trunk patch after that small change.  However, I should mention 
that I didn't review the bash changes.  [~aw], are you ready to +1 on the bash 
side, or do you have more feedback?

After a branch-2 patch is available, I'd like to retest there.

> Add hadoop --loglevel option to change log level
> ------------------------------------------------
>
>                 Key: HADOOP-7984
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7984
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: scripts
>            Reporter: Eli Collins
>            Assignee: Akira AJISAKA
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-7984-branch-2.patch, HADOOP-7984.3.patch, 
> HADOOP-7984.4.patch, HADOOP-7984.patch, HADOOP-7984.patch
>
>
> It would be helpful if bin/hadoop had --loglevel option to change the log 
> level. Currently users need to set an env variable or prefix the command (eg 
> "HADOOP_ROOT_LOGGER=DEBUG,console hadoop distcp") which isn't very user 
> friendly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to