[ 
https://issues.apache.org/jira/browse/HADOOP-11195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171246#comment-14171246
 ] 

Yongjun Zhang commented on HADOOP-11195:
----------------------------------------

Hi [~brandonli],

Thanks for looking into! I guess you meant the IdMappingConstant.java? I 
on-purposely left with the same names as in original nfs code for backward 
compatibility. e.g., the following properties all have "nfs" signature, 
changing them would break compatibility:
{code}
  public final static String NFS_USERGROUP_UPDATE_MILLIS_KEY = 
"nfs.usergroup.update.millis";
  // Used for finding the configured static mapping file.
  public static final String NFS_STATIC_MAPPING_FILE_KEY = 
"nfs.static.mapping.file";
  public static final String NFS_STATIC_MAPPING_FILE_DEFAULT = "/etc/nfs.map";
{code}

I should be able to drop the NFS in the following
{code}
public final static long NFS_USERGROUP_UPDATE_MILLIS_DEFAULT = 15 * 60 * 1000; 
// ms
public final static long NFS_USERGROUP_UPDATE_MILLIS_MIN = 1 * 60 * 1000; // ms
{code}

In future work, we can consider deprecate the property names and introduce new 
ones, but I think it'd be nice for the initial merge work for HADOOP-11195 to 
maintain backward compatibility.

Is this what you meant?  Thanks.




> Move Id-Name mapping in NFS to the hadoop-common area for better maintenance
> ----------------------------------------------------------------------------
>
>                 Key: HADOOP-11195
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11195
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HADOOP-11195.001.patch
>
>
> Per [~aw]'s suggestion in HDFS-7146, creating this jira to move the id-name 
> mapping implementation (IdUserGroup.java) to the framework that cache user 
> and group info in hadoop-common area 
> (hadoop-common/src/main/java/org/apache/hadoop/security) 
> Thanks [~brandonli] and [~aw] for the review and discussion in HDFS-7146.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to