[ 
https://issues.apache.org/jira/browse/HADOOP-9422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172802#comment-14172802
 ] 

Jason Lowe commented on HADOOP-9422:
------------------------------------

I think the findbugs and test failures are unrelated.

My only concern with the patch is the original author went out of their way to 
make sure we only computed the value once, and with this patch it will be 
recomputed each time getHadoopHome() is called.  Wondering if it's worth only 
computing it once, e.g.: use System.setProperty("hadoop.home.dir", ...) if that 
property is not already set so subsequent calls can do a quick lookup without 
resorting to filesystem operations in the worst-case every time.

> HADOOP_HOME should not be required to be set to be able to launch commands 
> using hadoop.util.Shell
> --------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9422
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Hitesh Shah
>            Assignee: Arpit Gupta
>         Attachments: HADOOP-9422.patch
>
>
> Not sure why this is an enforced requirement especially in cases where a 
> deployment is done using multiple tar-balls ( one each for 
> common/hdfs/mapreduce/yarn ). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to