[
https://issues.apache.org/jira/browse/HADOOP-10926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin Patrick McCabe updated HADOOP-10926:
------------------------------------------
Attachment: HADOOP-10926.002.patch
This patch adds a special case for git patches generated without \-\-no-prefix
as discussed above. This is a lot easier to do, since we don't need to search
for the patch root when applying such patches. This avoids the need to parse
the output on stdout of "git apply" and simplifies the application process for
such patches a lot. I use bash regexes in order to verify that a patch is a
git patch.
> Improve test-patch.sh to apply binary diffs
> -------------------------------------------
>
> Key: HADOOP-10926
> URL: https://issues.apache.org/jira/browse/HADOOP-10926
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Colin Patrick McCabe
> Fix For: 3.0.0
>
> Attachments: HADOOP-10926.001.patch, HADOOP-10926.002.patch
>
>
> The Unix {{patch}} command cannot apply binary diffs as generated via {{git
> diff --binary}}. This means we cannot get effective test-patch.sh runs when
> the patch requires adding a binary file.
> We should consider using a different patch method.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
