[
https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207769#comment-14207769
]
Tsuyoshi OZAWA commented on HADOOP-10365:
-----------------------------------------
[~yunsh] thanks for your quick updating. Minor nits: could you fix following
lines to conform to coding rule?
http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-142311.html#449
{code}
if (outputStream != null) outputStream.close();
{code}
{code}
if (outputStream != null) {
outputStream.close();
}
{code}
> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally
> block
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-10365
> URL: https://issues.apache.org/jira/browse/HADOOP-10365
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Reporter: Ted Yu
> Priority: Minor
> Attachments: HADOOP-10365.2.patch, HADOOP-10365.3.patch,
> HADOOP-10365.patch
>
>
> {code}
> BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));
> ...
> outputStream.flush();
> outputStream.close();
> {code}
> outputStream should be closed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
