[ 
https://issues.apache.org/jira/browse/HADOOP-11344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232489#comment-14232489
 ] 

Andrew Wang commented on HADOOP-11344:
--------------------------------------

This LGTM, only thing is I'd like a comment around that new if-statement 
explaining what we do in the different set/unset/null situations. +1 pending.

> KMS kms-config.sh sets a default value for the keystore password even in 
> non-ssl setup
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11344
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11344
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: HADOOP-11344.1.patch, HADOOP-11344.2.patch
>
>
> This results in kms always starting up in ssl mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to