[
https://issues.apache.org/jira/browse/HADOOP-11352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14235168#comment-14235168
]
Akira AJISAKA commented on HADOOP-11352:
----------------------------------------
bq. The only contrib source is under hadoop-hdfs/src/contrib/bkjournal
Oh, I was thinking that there were some contrib sources. Thanks for the
information.
bq. the question becomes "why didn't those tests run/get picked up".
HDFS-7097 did not change bkjournal at all, so the tests were not picked up.
HDFS-7448 changed bkjournal test code, so the tests were picked up.
I suggest removing the script to run contrib tests from test-patch.sh because
the script actually does no-op and the jira comment "+1 contrib tests" is
confusing.
> test-patch.sh doesn't run hadoop-hdfs/src/contrib/bkjournal
> -----------------------------------------------------------
>
> Key: HADOOP-11352
> URL: https://issues.apache.org/jira/browse/HADOOP-11352
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Akira AJISAKA
>
> Jenkins test-patch.sh always comments as "{color:green}+1 contrib
> tests{color}. The patch passed contrib unit tests.", however, the script
> runs no contrib tests.
> This issue was found when fixing HDFS-7448.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
