[
https://issues.apache.org/jira/browse/HADOOP-11349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239992#comment-14239992
]
Colin Patrick McCabe commented on HADOOP-11349:
-----------------------------------------------
I apologize if it seems like I'm nitpicking here, but I really don't like
catching Throwable.
Our usual idiom for this kind of thing is:
{code}
boolean success = false;
try {
out = ...
success = true;
} finally {
if (!success) {
IOUtils.cleanup(out)
}
}
{code}
This avoids the need to wrap the exception (or to rethrow the exception at all).
Thanks again for taking this one up, and sorry for the nitpick!
> RawLocalFileSystem leaks file descriptor while creating a file if creat
> succeeds but chmod fails.
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-11349
> URL: https://issues.apache.org/jira/browse/HADOOP-11349
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.6.0
> Reporter: Chris Nauroth
> Assignee: Varun Saxena
> Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11349.002.patch, HADOOP-11349.003.patch,
> HADOOP-11349.004.patch, HADOOP-11349.patch
>
>
> {{RawLocalFileSystem}} currently implements some file creation operations as
> a sequence of 2 syscalls: create the file, followed by setting its
> permissions. If creation succeeds, but then setting permission causes an
> exception to be thrown, then there is no attempt to close the previously
> opened file, resulting in a file descriptor leak.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
