[
https://issues.apache.org/jira/browse/HADOOP-11389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14241906#comment-14241906
]
Chris Nauroth commented on HADOOP-11389:
----------------------------------------
+1 for the basic approach, once we get a good Jenkins run. This is a really
minor nitpick, but could you please remove the extra blank line added to
{{FileBasedIPList}}?
{code}
try {
+
if (fileName != null) {
{code}
It brings me joy to see try-with-resources used in the Hadoop codebase! :-)
> Clean up byte to string encoding issues in hadoop-common
> --------------------------------------------------------
>
> Key: HADOOP-11389
> URL: https://issues.apache.org/jira/browse/HADOOP-11389
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HADOOP-11389.000.patch
>
>
> Much code in hadoop-common convert bytes to string using default charsets.
> The behavior of conversion depends on the platform settings of encoding,
> which is flagged by newer versions of findbugs. This jira proposes to fix the
> findbugs warnings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
