[
https://issues.apache.org/jira/browse/HADOOP-11398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14243620#comment-14243620
]
Hadoop QA commented on HADOOP-11398:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12686739/HADOOP-11398-121114.patch
against trunk revision 5b9fced.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5249//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5249//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5249//console
This message is automatically generated.
> RetryUpToMaximumTimeWithFixedSleep needs to behave more accurately
> ------------------------------------------------------------------
>
> Key: HADOOP-11398
> URL: https://issues.apache.org/jira/browse/HADOOP-11398
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Li Lu
> Assignee: Li Lu
> Attachments: HADOOP-11398-121114.patch
>
>
> RetryUpToMaximumTimeWithFixedSleep now inherits
> RetryUpToMaximumCountWithFixedSleep and just acts as a wrapper to decide
> maxRetries. The current implementation uses (maxTime / sleepTime) as the
> number of maxRetries. This is fine if the actual for each retry is
> significantly less than the sleep time, but it becomes less accurate if each
> retry takes comparable amount of time as the sleep time. The problem gets
> worse when there are underlying retries.
> We may want to use timers inside RetryUpToMaximumTimeWithFixedSleep to
> perform accurate timing.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
