[
https://issues.apache.org/jira/browse/HADOOP-11410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247546#comment-14247546
]
Colin Patrick McCabe commented on HADOOP-11410:
-----------------------------------------------
bq. Patch looks pretty good to me, Colin. Can you perhaps comment on what
testing you've done of this change? It seems quite straightforward to me, but
it'd be good if you could let us know what verification of this you've done.
I built with and without {{\-Dextra.libhadoop.rpath=/tmp/foo}} and verified
that the RPATH was as expected using {{chrpath -l}}
One small suggestion on the actual contents of the patch: given that we're now
adding $ORIGIN into the RPATH before the SET_TARGET_PROPERTIES call, seems like
it'd be better to move the associated comment explaining the purpose of that up
as well.
yeah
> make the rpath of libhadoop.so configurable
> --------------------------------------------
>
> Key: HADOOP-11410
> URL: https://issues.apache.org/jira/browse/HADOOP-11410
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.7.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-11410.001.patch
>
>
> We should make the rpath of {{libhadoop.so}} configurable, so that we can use
> a different rpath if needed. The {{RPATH}} of {{libhadoop.so}} is primarily
> used to control where {{dlopen}} looks for shared libraries by default.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
