[ 
https://issues.apache.org/jira/browse/HADOOP-11385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14250749#comment-14250749
 ] 

Hadoop QA commented on HADOOP-11385:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12687834/HADOOP-11385.000.patch
  against trunk revision f2d150e.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 2 new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The following test timeouts occurred in 
hadoop-common-project/hadoop-common:

org.apache.hadoop.http.TestHttpServerLifecycle

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5294//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5294//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/5294//console

This message is automatically generated.

> Cross site scripting attack on JMXJSONServlet
> ---------------------------------------------
>
>                 Key: HADOOP-11385
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11385
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>            Priority: Critical
>         Attachments: HADOOP-11385.000.patch
>
>
> JMXJSONServlet allows passing a callback parameter in the JMX response, which 
> is introduced in HADOOP-8922:
> {code}
>         // "callback" parameter implies JSONP outpout
>         jsonpcb = request.getParameter(CALLBACK_PARAM);
>         if (jsonpcb != null) {
>           response.setContentType("application/javascript; charset=utf8");
>           writer.write(jsonpcb + "(");
>         } else {
>           response.setContentType("application/json; charset=utf8");
>         }
> {code}
> The code writes the callback parameter directly to the output, allowing 
> cross-site scripting attack. This vulnerability allows the attacker easily 
> stealing the credential of the user on the browser.
> The original use case can be supported using Cross-origin resource sharing 
> (CORS), which is used by the current NN web UI.
> This jira proposes to move JMXJSONServlet to CORS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to