[
https://issues.apache.org/jira/browse/HADOOP-11430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252823#comment-14252823
]
Hadoop QA commented on HADOOP-11430:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688169/HADOOP-11430.001.patch
against trunk revision b0b9084.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 3 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.server.blockmanagement.TestDatanodeManager
org.apache.hadoop.fs.TestSymlinkHdfsFileContext
org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureToleration
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5306//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5306//artifact/patchprocess/newPatchFindbugsWarningshadoop-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5306//artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/5306//console
This message is automatically generated.
> Add GenericTestUtils#disableLog, GenericTestUtils#setLogLevel
> -------------------------------------------------------------
>
> Key: HADOOP-11430
> URL: https://issues.apache.org/jira/browse/HADOOP-11430
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.6.0
> Reporter: Colin Patrick McCabe
> Assignee: Colin Patrick McCabe
> Attachments: HADOOP-11430.001.patch
>
>
> Now that we are using both commons-logging and slf4j, we can no longer rely
> on just casting the Log object to a {{Log4JLogger}} and calling {{setLevel}}
> on that. With {{org.slf4j.Logger}} objects, we need to look up the
> underlying {{Log4JLogger}} using {{LogManager#getLogger}}.
> This patch adds {{GenericTestUtils#disableLog}} and
> {{GenericTestUtils#setLogLevel}} functions which hide this complexity from
> unit tests, just allowing the tests to call {{disableLog}} or
> {{setLogLevel}}, and have {{GenericTestUtils}} figure out the right thing to
> do based on the log / logger type.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
