[
https://issues.apache.org/jira/browse/HADOOP-11032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254479#comment-14254479
]
Tsuyoshi OZAWA commented on HADOOP-11032:
-----------------------------------------
Thanks for your review, [~sjlee0]! Uploading v6 patch to address your
comments.
StopWatch.java
* Removing needless calls
* Checking state before calling System.nanoTime()
* Renaming members to include the time unit "nano"
* Saying "this instance of StopWatch" in javadoc
* Using Closesable instead of AutoCloseable for JDK6 - I know that we're only
use JDK7+, but I don't find any reason to use AutoCloseable.
* Removing usages of Preconditions.checkState(). Maybe we can have these kind
of simple utility by ourselves.
Other classes
* Changing mapred/FileInputFormat to call now(TimeUnit.MILLISECONDS)
* Removing needless packages.
> Replace use of Guava Stopwatch with Apache StopWatch
> ----------------------------------------------------
>
> Key: HADOOP-11032
> URL: https://issues.apache.org/jira/browse/HADOOP-11032
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Gary Steelman
> Assignee: Tsuyoshi OZAWA
> Attachments: HADOOP-11032.1.patch, HADOOP-11032.2.patch,
> HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.3.patch,
> HADOOP-11032.3.patch, HADOOP-11032.3.patch, HADOOP-11032.4.patch,
> HADOOP-11032.5.patch, HADOOP-11032.6.patch
>
>
> This patch reduces Hadoop's dependency on an old version of guava.
> Stopwatch.elapsedMillis() isn't part of guava past v16 and the tools I'm
> working on use v17.
> To remedy this and also reduce Hadoop's reliance on old versions of guava, we
> can use the Apache StopWatch (org.apache.commons.lang.time.StopWatch) which
> provides nearly equivalent functionality. apache.commons.lang is already a
> dependency for Hadoop so this will not introduce new dependencies.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
