[ 
https://issues.apache.org/jira/browse/HADOOP-11171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255240#comment-14255240
 ] 

Steve Loughran commented on HADOOP-11171:
-----------------------------------------

I can't test this; I have looked at the code and tests to see that (a) the new 
code doesn't break anything existing and (b) the tests do check that parameters 
are validated and that some bad settings are picked up.

{{S3AFileSystem}}
* p140: what if a field like password or domain is not supplied. Is setting 
them to null acceptable? I presume so, based on the testsl
* p145, SLF4Jj handles the stringification of vararg elements, even null ones 
—so you can cut te String.valueOf.
* {{TestS3AConfiguration}}. Can you rethrow invalid exceptions, such as 
{code}
  if (!e.getMessage().contains(proxy + " refused")) {
    throw e;
  }

{code}
This will help debug why a test is failing.

> Enable using a proxy server to connect to S3a.
> ----------------------------------------------
>
>                 Key: HADOOP-11171
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11171
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: fs/s3
>    Affects Versions: 2.4.0
>            Reporter: Thomas Demoor
>            Assignee: Thomas Demoor
>              Labels: amazon, s3
>         Attachments: HADOOP-11171-2.patch, HADOOP-11171-3.patch, 
> HADOOP-11171-4.patch, HADOOP-11171-5.patch, HADOOP-11171-6.patch, 
> HADOOP-11171-7.patch, HADOOP-11171.patch
>
>
> This exposes the AWS SDK config for a proxy (host and port) to s3a through 
> config settings.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to