[
https://issues.apache.org/jira/browse/HADOOP-11283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258762#comment-14258762
]
Tsuyoshi OZAWA commented on HADOOP-11283:
-----------------------------------------
+1
> Potentially unclosed SequenceFile.Writer in DistCpV1#setup()
> ------------------------------------------------------------
>
> Key: HADOOP-11283
> URL: https://issues.apache.org/jira/browse/HADOOP-11283
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Varun Saxena
> Priority: Minor
> Fix For: 2.7.0
>
> Attachments: HADOOP-11283.001.patch, HADOOP-11283.002.patch,
> HADOOP-11283.patch
>
>
> {code}
> SequenceFile.Writer src_writer = SequenceFile.createWriter(jobfs, jobConf,
> srcfilelist, LongWritable.class, FilePair.class,
> SequenceFile.CompressionType.NONE);
> Path dstfilelist = new Path(jobDirectory, "_distcp_dst_files");
> SequenceFile.Writer dst_writer = SequenceFile.createWriter(jobfs, jobConf,
> dstfilelist, Text.class, Text.class,
> SequenceFile.CompressionType.NONE);
> {code}
> If creation of dst_writer throws exception, src_writer would be left unclosed
> since there is no finally clause doing that for the above code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
