[ 
https://issues.apache.org/jira/browse/HADOOP-11464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14268697#comment-14268697
 ] 

Allen Wittenauer commented on HADOOP-11464:
-------------------------------------------

I'm still working on getting an environment to test this, but a few things pop 
out:

* I suspect that java.library.path/JAVA_LIBRARY_PATH needs to get mangled in 
hadoop_finalize_libpaths for Windows as well.

* shellcheck is throwing four new warnings:
{code}
In ./hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh line 
667:
      eval $1='`cygpath -p -w "${!1}" 2>/dev/null`'
           ^-- SC2086: Double quote to prevent globbing and word splitting.
              ^-- SC2016: Expressions don't expand in single quotes, use double 
quotes for that.


In ./hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh line 
669:
      eval $1='`cygpath -w "${!1}" 2>/dev/null`'
           ^-- SC2086: Double quote to prevent globbing and word splitting.
              ^-- SC2016: Expressions don't expand in single quotes, use double 
quotes for that.
{code}

(I really need to get the shell test bits written up...)

* To support the tomcat bits (kms and eventually httpfs), the 
hadoop_finalize_catalina_opts function is going to need some work.  Of course, 
we can always punt on that till later.

* We should probably change the comment in hadoop_os_tricks tricks now.

* Because yarn is (or at least was) idiotic, it adds some custom stuff to 
HADOOP_OPTS in bin/yarn that probably need to be looked over.  Of course, if 
someone says we don't need them anymore, I'd much rather they go away.

> Reinstate support for launching Hadoop processes on Windows using Cygwin.
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-11464
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11464
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: bin
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-11464-branch-2.001.patch, 
> HADOOP-11464-branch-2.002.patch, HADOOP-11464.001.patch, 
> HADOOP-11464.002.patch
>
>
> The Windows compatibility work removed the dependency on Cygwin as a 
> compatibility layer.  However, some users may still wish to run Cygwin on a 
> personal machine for running Hadoop commands that interact with a cluster.  
> This issue proposes to reinstate support for launching Hadoop processes on 
> Windows using Cygwin to call the bash scripts.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to